WIP: AVRO-3986: [csharp] - Plain JSON encoding for Apache Avro #2888
Conversation
opwvhk
changed the title
|
Hi, I believe this PR has been marked as |
The PR diff shows modified files in C#, Java and Rust. |
github-actions
bot
removed
Java
I bungled a merge during an update and dragged a bunch of stuff in that didn't belong. I just rebased and cleaned that up. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Interesting. The tool contains about upcasts of the form whereby the upcast to object from DateTime is flagged. The cast is required for the cast to (T) to compile and will indeed fail at runtime if there's a mismatch. So that looks like a false positive. |
[Do not merge.]
This PR accompanies my filing of AVRO-3986 and implements all features defined in the issue. Purpose of the PR is also to illustrate the scope of the work for the other languages. New tests have been added to account for the different modes and the added features.
It's obviously possible to break up the umbrella issue into multiple issues and to break up the PR into separate issues, but since the interoperability goal is only achieved by the sum of the features, I put it all into one. The majority of the new code is related to union handling (features 5 and 6) and RFC3339 date-time handling.